fix #304906 Update Piano Levels Filter to shift to the new Fraction based note measurement system #6043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Jojo-Schmitz
approved these changes
May 5, 2020
This was referenced May 6, 2020
anatoly-os
reviewed
May 12, 2020
There was a problem hiding this comment.
@blackears could you please make a separate PR with all those changes related to uncommenting operator/() and operator/=(), renaming methods, etc.?
Please, keep only the necessary changes to fix the actual tooltips in this PR.
blackears
force-pushed
the
304906-improve-pre-tooltips-3
branch
from
1f89d24
to
575e854
Compare
blackears
changed the title
…ased note measurement system Upgrading the Piano Levels Filter system to use Fration of whole note instead of ticks. Selecting a single note now updates the Set box. Changes to tooltip descriptions of filters. Can now use negative values for specifying note lengths.
blackears
force-pushed
the
304906-improve-pre-tooltips-3
branch
from
575e854
to
e6ec376
Compare
blackears
changed the title
29 tasks
anatoly-os
added a commit
that referenced
this pull request
May 20, 2020
fix #304906 Update Piano Levels Filter to shift to the new Fraction based note measurement system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading the Piano Levels Filter system to use Fration of whole note instead of ticks.
Selecting a single note now updates the Set box.
Changes to tooltip descriptions of filters.
Can now use negative values for specifying note lengths.
Resolves: (direct link to the issue)
(short description of the changes and the motivation to make the changes)